Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Half/BFloat16 in topk #7755

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Support Half/BFloat16 in topk #7755

merged 2 commits into from
Jan 22, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 18, 2025

Partial fix for #7748.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 18, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Jan 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7755

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2025
swolchok added a commit that referenced this pull request Jan 18, 2025
ghstack-source-id: 62412fb8472652c989f28eb2a18ecb2dee0a597b
ghstack-comment-id: 2599393791
Pull Request resolved: #7755
@swolchok swolchok requested review from manuelcandales and kirklandsign and removed request for manuelcandales January 18, 2025 00:05
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 18, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 22, 2025
ghstack-source-id: c3fb4df9a4cb2ce8b32af2ddbae901438f203d81
ghstack-comment-id: 2599393791
Pull Request resolved: #7755
@swolchok
Copy link
Contributor Author

merging because last update was just a lint fix and previous runs were green

@swolchok swolchok merged commit 4089f2a into main Jan 22, 2025
40 of 41 checks passed
@swolchok swolchok deleted the gh/swolchok/146/head branch January 22, 2025 17:44
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants